Conversation
| defer span.End() | ||
|
|
||
| currentEpoch := slots.ToEpoch(s.TimeFetcher.CurrentSlot()) | ||
| if currentEpoch < params.BeaconConfig().GloasForkEpoch { |
There was a problem hiding this comment.
we need these guards right?
| continue | ||
| } | ||
|
|
||
| if err := s.Broadcaster.Broadcast(ctx, consensusMsg); err != nil { |
There was a problem hiding this comment.
do i just insert it into the pool or do I also broadcast here?
There was a problem hiding this comment.
I think both. At least it should mirror how we handle beacon attestation
|
|
||
| var data []*structs.PayloadAttestation | ||
| for _, att := range allAtts { | ||
| if rawSlot != "" && att.Data.Slot != primitives.Slot(slot) { |
There was a problem hiding this comment.
is filtering this way safe? or is having a separate function on the pool better?
| BlockRewardFetcher rewards.BlockRewardsFetcher | ||
| TrackedValidatorsCache *cache.TrackedValidatorsCache | ||
| PayloadIDCache *cache.PayloadIDCache | ||
| PayloadAttestationPool payloadattestation.PoolManager |
There was a problem hiding this comment.
these are not initialized anywhere for now
|
|
||
| // PayloadStatusFetcher determines the payload presence and blob data availability | ||
| // for a given slot. This is used by PTC validators to produce PayloadAttestationData. | ||
| type PayloadStatusFetcher interface { |
There was a problem hiding this comment.
I dont think this would be implemented in pool package
i think this would be implemented in blockchainpackage
but i could be wrong
There was a problem hiding this comment.
the attestation pools live here under attestations folder so i thought it would be the same
2 participants
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements the following endpoints
GET /eth/v1/validator/payload_attestation_data/{slot}
POST /eth/v1/beacon/pool/payload_attestations
GET /eth/v1/beacon/pool/payload_attestations
NOTE: DOES NOT IMPLEMENT POOL AND USES INTERFACE STUBS, DOES NOT IMPLEMENT gRPC
Which issues(s) does this PR fix?
references ethereum/beacon-APIs#552
Other notes for review
Acknowledgements