sha3 xor metric

[subtly]

No description provided.

[chriseth]

Wouldn't it be better to directly use the sha3 of the address as NodeId, or at least store it inside Nodeid?

[subtly]

@chriseth Perhaps as an optimization. The output of the distance is already being stored.

[gavofyork]

is this called often? sha3 is not an especially quick function to be calling...

[subtly]

Not often. It's called by the constructor of NodeEntry and the result is stored in a property.

[fjl]

For cross-reference, the go-ethereum PR is here: ethereum/go-ethereum#791.
The Go PR implements a protocol change which makes findnode target hash sized instead of
public key sized.

Will submit a devp2p PR for that. If you don't accept this change, I'll roll it back in Go.

[fjl]

ethereum/devp2p#25 is the protocol change request.