Discovery findnode should have hash-sized target#25
Closed
fjl wants to merge 1 commit into
Closed
Conversation
Member
|
Deferred until after Frontier. It's also moot because, as previously discussed, the target is to be removed and replaced with a pre-calculated integer distance value. We are using this to find random nodes which are only nearby, so an exact target isn't required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly a performance concern. With a hash-sized target, it does not need to be hashed by the recipient in order to compute the closest nodes.
The other reason why this might be a good change is that calling it a NodeID is wrong in general.
The lookup target is arbitrary and does not need to be a valid EC public key. We could leave it at 64
bytes, but it then needs to be hashed anyway in order to fit into the distance metric.