p2p/discover: sha3-based node distance#791
Merged
Merged
Conversation
There was a problem hiding this comment.
perhaps use uint16 for consistency with Node.UDP/TCP and to catch potential future overflow bugs quicker
There was a problem hiding this comment.
Ah, nevermind, I see it's used due to strconv.ParseUInt returning uint64.
fjl
force-pushed
the
discover-sha3-distance
branch
4 times, most recently
from
1486ee6 to
a2737d9
Compare
Contributor
Author
|
This needs a rebase on #743. |
fjl
force-pushed
the
discover-sha3-distance
branch
2 times, most recently
from
de4c8a0 to
6dbfa10
Compare
This commit changes the discovery protocol to use the new "v4" endpoint format, which allows for separate UDP and TCP ports and makes it possible to discover the UDP address after NAT.
fjl
force-pushed
the
discover-sha3-distance
branch
from
6dbfa10 to
ccac4a7
Compare
Contributor
Author
|
Has been rebased. |
fjl
force-pushed
the
discover-sha3-distance
branch
from
ccac4a7 to
52f5435
Compare
The previous metric was pubkey1^pubkey2, as specified in the Kademlia paper. We missed that EC public keys are not uniformly distributed. Using the hash of the public keys addresses that. It also makes it a bit harder to generate node IDs that are close to a particular node.
fjl
force-pushed
the
discover-sha3-distance
branch
from
52f5435 to
2adcc31
Compare
obscuren
added a commit
that referenced
this pull request
May 6, 2015
p2p/discover: sha3-based node distance
hodler-smart
added a commit
to hodler-smart/go-ethereum
that referenced
this pull request
Feb 4, 2021
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jun 9, 2023
internal/ethapi: set rpc gas cap as default gas limit when creating access list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the endpoint format changes (#743) mostly to reduce merge trouble later.