Holocene: eip-1559 parameters in extraData

[roberto-bayardo]

Description

EIP-1559 parameters need to be in the ExecutionPayload, not just the PayloadAttributes, to allow geth to properly include the encoded parameters in the block header. So instead of using nonce, we use the extraData field which is already in the ExecutionPayload. This will also reserve nonce to be used for sub-second block times.

[roberto-bayardo]

As discussed in discord, updated spec to use extraData instead of nonce.

[clabby]

lgtm. If we want, we can also take this opportunity to address your nitpick in the encoding: denominator, elasticity -> elasticity, denominator.

[roberto-bayardo]

lgtm. If we want, we can also take this opportunity to address your nitpick in the encoding: denominator, elasticity -> elasticity, denominator.

Thanks, given the geth impl is all using this order now, may as well leave it be given how minor this is.

[tynes]

Looks good to me, would should let @protolambda have a final say before merge

[tynes]

Just to clarify, no need to add a new p2p topic correct?

[roberto-bayardo]

Just to clarify, no need to add a new p2p topic correct?

Correct, we are no longer changing ExecutionPayload since it already contains the ExtraData field.

[roberto-bayardo]

Just to clarify, no need to add a new p2p topic correct?

Correct, we are no longer changing ExecutionPayload since it already contains the ExtraData field.