Add eip1559 params to payload by cody-wang-cb · Pull Request #11473 · paradigmxyz/reth

cody-wang-cb · 2024-10-04T06:02:34Z

Part of Holocene changes to add EIP1559 params to payload, and using the nonce field in block header to store the value.

Spec: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md

crates/optimism/evm/src/lib.rs

crates/optimism/payload/src/payload.rs

crates/optimism/payload/src/builder.rs

crates/optimism/chainspec/src/lib.rs

crates/optimism/payload/src/builder.rs

refcell

Nice work!

tynes · 2024-10-07T18:49:05Z

The spec can be found here: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md

crates/optimism/chainspec/src/lib.rs

crates/optimism/payload/src/builder.rs

crates/optimism/chainspec/src/lib.rs

Rjected · 2024-10-07T20:18:11Z

crates/ethereum/engine-primitives/src/payload.rs

+impl Default for EthPayloadBuilderAttributes {
+    fn default() -> Self {
+        Self {
+            id: PayloadId::new([0; 8]),
+            parent: B256::default(),
+            timestamp: 0,
+            suggested_fee_recipient: Address::ZERO,
+            prev_randao: B256::default(),
+            withdrawals: Withdrawals::default(),
+            parent_beacon_block_root: None,
+        }
+    }
+}


this can probably be derived

Requires this change in alloy I think, PTAL
alloy-rs/alloy#1442

crates/optimism/payload/src/payload.rs

crates/optimism/chainspec/src/lib.rs

crates/optimism/payload/src/builder.rs

crates/optimism/node/src/engine.rs

tynes · 2024-10-10T00:32:31Z

The consensus rules look good to me

cody-wang-cb · 2024-10-10T22:42:06Z

This PR is ready for final reviews if any of you want to give another look at it
@clabby @tynes @Rjected @mattsse

mattsse

@cody-wang-cb any new spec changes we need to include here?

if not I'm getting this over the line tmrw

Rjected

@mattsse the spec will most likely use extraData now for the 1559 params: ethereum-optimism/specs#428 so it looks like this will need to change to not have it in the nonce field

cody-wang-cb · 2024-10-17T17:08:32Z

Hey @mattsse, @Rjected is right that I still need to update the new spec changes, I'm thinking about creating a separate PR

Rjected · 2024-10-17T17:31:41Z

Hey @mattsse, @Rjected is right that I still need to update the new spec changes, I'm thinking about creating a separate PR

Yeah we still need the newest spec details (extraData stuff), and creating a separate PR is a good idea

mattsse · 2024-10-30T13:51:50Z

with #11887 do we still need this?

cody-wang-cb · 2024-10-30T16:02:52Z

Nope i can close this!

add eip1559 params to payload

c36ed2c

cody-wang-cb requested review from Rjected, emhane, fgimenez, gakonst and mattsse as code owners October 4, 2024 06:02

cody-wang-cb marked this pull request as draft October 4, 2024 06:02

mattsse reviewed Oct 4, 2024

View reviewed changes

crates/optimism/evm/src/lib.rs Outdated Show resolved Hide resolved

crates/optimism/evm/src/lib.rs Outdated Show resolved Hide resolved

crates/optimism/payload/src/payload.rs Outdated Show resolved Hide resolved

cody-wang-cb added 2 commits October 4, 2024 03:43

add default base fee param

ff09c2e

move fee fetching to opchainspec

84a47ef

cody-wang-cb force-pushed the cody/eip1559-params branch from 1651917 to 84a47ef Compare October 7, 2024 17:29

cody-wang-cb commented Oct 7, 2024

View reviewed changes

crates/optimism/payload/src/builder.rs Show resolved Hide resolved

add eip1559 params check when holocene is activated

ad9dd5a

refcell reviewed Oct 7, 2024

View reviewed changes

crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved

refcell reviewed Oct 7, 2024

View reviewed changes

crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved

refcell reviewed Oct 7, 2024

View reviewed changes

crates/optimism/payload/src/builder.rs Show resolved Hide resolved

refcell reviewed Oct 7, 2024

View reviewed changes

tynes reviewed Oct 7, 2024

View reviewed changes

crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved

clabby reviewed Oct 7, 2024

View reviewed changes

crates/optimism/payload/src/builder.rs Show resolved Hide resolved

crates/optimism/chainspec/src/lib.rs Show resolved Hide resolved

Rjected reviewed Oct 7, 2024

View reviewed changes

add not first holocene block check

ea57b2a

cody-wang-cb force-pushed the cody/eip1559-params branch from b72cb4a to ea57b2a Compare October 7, 2024 22:14

cody-wang-cb added 2 commits October 8, 2024 19:49

merge from main

a198ed4

fix import

e38af26

cody-wang-cb changed the title ~~(DRAFT) Add eip1559 params to payload~~ Add eip1559 params to payload Oct 9, 2024

cody-wang-cb marked this pull request as ready for review October 9, 2024 00:10

cody-wang-cb added 2 commits October 8, 2024 22:08

fix test

1f3e593

fix lint

b7db1f6

clabby reviewed Oct 9, 2024

View reviewed changes

crates/optimism/payload/src/payload.rs Show resolved Hide resolved

clabby reviewed Oct 9, 2024

View reviewed changes

crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved

clabby reviewed Oct 9, 2024

View reviewed changes

crates/optimism/payload/src/builder.rs Show resolved Hide resolved

cody-wang-cb added 4 commits October 9, 2024 14:57

add check in engine validator; add 1559 params to payload hasher

f4130b8

merge from main

abf8d08

add zero denominator check

40937cf

fix lint

8dc0b36

cody-wang-cb force-pushed the cody/eip1559-params branch from fc826a5 to 8dc0b36 Compare October 9, 2024 20:44

attempt to add unit test for invalid checks

8f59e9c

cody-wang-cb commented Oct 9, 2024

View reviewed changes

crates/optimism/node/src/engine.rs Outdated Show resolved Hide resolved

tynes reviewed Oct 10, 2024

View reviewed changes

crates/optimism/node/src/engine.rs Outdated Show resolved Hide resolved

cody-wang-cb added 2 commits October 10, 2024 18:22

fix test

499e8ca

lint

bf74b38

cody-wang-cb requested a review from clabby October 11, 2024 18:35

clabby approved these changes Oct 11, 2024

View reviewed changes

mattsse reviewed Oct 17, 2024

View reviewed changes

Rjected reviewed Oct 17, 2024

View reviewed changes

cody-wang-cb closed this Oct 30, 2024

Conversation

cody-wang-cb commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refcell left a comment

Choose a reason for hiding this comment

Uh oh!

tynes commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rjected Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

cody-wang-cb Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tynes commented Oct 10, 2024

Uh oh!

cody-wang-cb commented Oct 10, 2024

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Rjected left a comment

Choose a reason for hiding this comment

Uh oh!

cody-wang-cb commented Oct 17, 2024

Uh oh!

Rjected commented Oct 17, 2024

Uh oh!

mattsse commented Oct 30, 2024

Uh oh!

cody-wang-cb commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cody-wang-cb commented Oct 4, 2024 •

edited

Loading