Add eip1559 params to executable payload#1480
Closed
cody-wang-cb wants to merge 2 commits intoalloy-rs:mainfrom
Closed
Add eip1559 params to executable payload#1480cody-wang-cb wants to merge 2 commits intoalloy-rs:mainfrom
cody-wang-cb wants to merge 2 commits intoalloy-rs:mainfrom
Conversation
cody-wang-cb
requested review from
DaniPopes,
emhane,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
mattsse
approved these changes
Oct 15, 2024
mattsse
reviewed
Oct 15, 2024
Comment on lines
+335
to
+336
| /// Array of hex[`u64`] representing the EIP-1559 parameters, enabled with V3 | ||
| pub eip_1559_params: B64, |
Member
There was a problem hiding this comment.
how will this be rolled out, will this just be a default value until this is activated?
mattsse
requested changes
Oct 15, 2024
Comment on lines
+335
to
+336
| /// Array of hex[`u64`] representing the EIP-1559 parameters, enabled with V3 | ||
| pub eip_1559_params: B64, |
Member
There was a problem hiding this comment.
we can't do this, this is an op specific change.
this would break existing engine API because this field doesn't exist.
looks like we need to roll an op specific v3 type
Contributor
Author
There was a problem hiding this comment.
Yeah I just realized as well, I should add this in op-alloy
Member
|
I believe this should also be optional |
Member
|
closing per ethereum-optimism/specs#428 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Required for Holocene EL changes
ethereum-optimism/specs#428
Solution
PR Checklist