Skip to content

Comments

ops: use list syntax for env_file#640

Merged
snario merged 1 commit intomasterfrom
fix/ops-dc
Apr 26, 2021
Merged

ops: use list syntax for env_file#640
snario merged 1 commit intomasterfrom
fix/ops-dc

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Apr 26, 2021

Description
This PR turns the env_file syntax into using an array instead of an object. According to the docs, this is the correct syntax

Metadata

  • Hopefully fixes problems with docker-compose on osx

@tynes tynes requested a review from karlfloersch as a code owner April 26, 2021 20:35
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2021

⚠️ No Changeset found

Latest commit: 2c1a566

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

smartcontracts
smartcontracts reviewed Apr 26, 2021
View reviewed changes
ops/docker-compose.yml
entrypoint: ./dtl.sh
env_file:
./envs/dtl.env
- ./envs/dtl.env
Copy link
Contributor

@smartcontracts smartcontracts Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indent is off here

Copy link
Contributor Author

@tynes tynes Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its technically valid syntax with or without the ident for lists, i was following the way that it is done in this file already to maintain the same syntax, the services.xyz.ports is indented

@tynes tynes requested a review from snario April 26, 2021 23:49
@snario snario merged commit 12881b4 into master Apr 26, 2021
@snario snario deleted the fix/ops-dc branch April 26, 2021 23:57
maurelian pushed a commit that referenced this pull request Apr 29, 2021
@tynes @maurelian
ops: use list syntax for env_file (#640)
f7e8681
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@tynes
ops: use list syntax for env_file (ethereum-optimism#640)
6cf2583
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell @github-merge-queue
Update Monorepo Commit (#640)
cec159c 
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
@sadiq1971 @dhyaniarun1993 @emhane
chore: moved proof initialization to reth-optimism-node (#640)
ad4c82f 
Closes #612

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
@sadiq1971 @dhyaniarun1993 @emhane
chore: moved proof initialization to reth-optimism-node (#640)
599ec9c 
Closes #612

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
@sadiq1971 @dhyaniarun1993 @emhane
chore: moved proof initialization to reth-optimism-node (#640)
bd0f7ab 
Closes #612

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
@sadiq1971 @dhyaniarun1993 @emhane
chore: moved proof initialization to reth-optimism-node (#640)
eebe458 
Closes #612

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts left review comments

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

@gakonst gakonst Awaiting requested review from gakonst

@maurelian maurelian Awaiting requested review from maurelian

+1 more reviewer

@snario snario snario approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @snario @smartcontracts