Skip to content

ops: use list syntax for env_file #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snario merged 1 commit into from
Apr 26, 2021
Merged

ops: use list syntax for env_file #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ops/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ services:
# override with the dtl script and the env vars required for it
entrypoint: ./dtl.sh
env_file:
./envs/dtl.env
- ./envs/dtl.env
Copy link
Contributor

@smartcontracts smartcontracts Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indent is off here

Copy link
Contributor Author

@tynes tynes Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its technically valid syntax with or without the ident for lists, i was following the way that it is done in this file already to maintain the same syntax, the services.xyz.ports is indented

# set the rest of the env vars for the network whcih do not
# depend on the docker-compose setup
environment:
Expand All @@ -68,7 +68,7 @@ services:
# override with the geth script and the env vars required for it
entrypoint: sh ./geth.sh
env_file:
./envs/geth.env
- ./envs/geth.env
environment:
ETH1_HTTP: http://l1_chain:8545
ROLLUP_STATE_DUMP_PATH: http://deployer:8081/state-dump.latest.json
Expand Down Expand Up @@ -105,7 +105,7 @@ services:
dockerfile: ./ops/docker/Dockerfile.batch-submitter
entrypoint: ./batches.sh
env_file:
./envs/batches.env
- ./envs/batches.env
environment:
L1_NODE_WEB3_URL: http://l1_chain:8545
L2_NODE_WEB3_URL: http://l2geth:8545
Expand Down