contracts-bedrock: fix compiler warning#5493
Merged
OptimismBot merged 2 commits intodevelopfrom Apr 19, 2023
Merged
Conversation
Adds a `pure` modifier to a test contract's method to silence a compiler warning.
|
✅ Deploy Preview for opstack-docs canceled.
|
maurelian
approved these changes
Apr 19, 2023
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
refcell
approved these changes
Apr 19, 2023
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Forgot to add this in XDM re-entrancy fix pr. LGTM
seolaoh
added a commit
to kroma-network/kroma
that referenced
this pull request
Aug 9, 2023
`CrossDomainMessager` whereby `relayMessage` naively reset the `xDomainMsgSender` after a call. The issue here was that a nested call would reset this value to the `Constants.DEFAULT_L2_SENDER` which deviates from the expected behavior that the `xDomainMsgSender` is set to the `_sender` for the entirety of the subcall. This change sets a message as failed upon re-entry to the `relayMessage` function by checking the value of `xDomainMsgSender`. We then also remove the `reentrancyLocks` from storage and don't have to worry about re-entrency here since any subcall through the `SafeCall` lib to the XDM `relayMessage` will be caught and recorded as failed by the aforementioned `xDomainMsgSender` check. Also removes the revert in `relayMessage` when the minimum gas threshold is not met. See: - ethereum-optimism/optimism#5475 - ethereum-optimism/optimism#5444 - ethereum-optimism/optimism#5493 - ethereum-optimism/optimism#5508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
puremodifier to a test contract's method to silence a compiler warning.