feat(ctb): Fail relayed XDM messages on reentry

[maurelian]

Description

This PR is an alternative to #5440.

The solution implementation as well as fuzz tests are included in this PR. Invariant testing will be split out to properly iterate and introduce invariant testing.

The sherlock-identified issue in the CrossDomainMessager whereby relayMessage naively reset the xDomainMsgSender after a call. The issue here was that a nested call would reset this value to the Constants.DEFAULT_L2_SENDER which deviates from the expected behavior that the xDomainMsgSender is set to the _sender for the entirety of the subcall.

As opposed to the minimal solution outlined in #5440, this change sets a message as failed upon re-entry to the relayMessage function by checking the value of xDomainMsgSender.

This check is a simple addition of the following

+ // Another message is being relayed, so we just store this for future replay.
+ if (xDomainMsgSender != Constants.DEFAULT_L2_SENDER) {
+     failedMessages[versionedHash] = true;
+     return;
+ }

We then also remove the reentrancyLocks from storage and don't have to worry about re-entrency here since any subcall through the SafeCall lib to the XDM relayMessage will be caught and recorded as failed by the aforementioned xDomainMsgSender check.

Benefits of this solution

• Removes the reentrancyLocks saving SSTOREs and SLOADs as well as removing the storage mapping altogether.
• Removes more complexity and proverbially "bites the bullet" now to deal with re-entry.

Potential Solution Cons

• Deviates from the suggested minimal-solution from multiple sherlock finding reports.
• Changes state and the codepaths from what has been audited.

Metadata

Fixes CLI-3834

[changeset-bot]

⚠️ No Changeset found

Latest commit: aae9e54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	aae9e54
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/643f3276c478b6000884469a

[tynes]

This definitely seems quite sane, just be sure to squash commits when ready for review

[tynes]

I'm trying to build the bindings locally to see if i get a diff

[mergify]

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

[maurelian]

I'm unable to approve since I opened the PR, but LGTM other than one nit in a test file.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.