Skip to content

op-wheel,op-service: create op-wheel, and extend op-service base functionality#4284

Merged
mslipper merged 1 commit intodevelopfrom
op-wheel-base
Dec 7, 2022
Merged

op-wheel,op-service: create op-wheel, and extend op-service base functionality#4284
mslipper merged 1 commit intodevelopfrom
op-wheel-base

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented Dec 7, 2022

Description

op-wheel is a new module that defines a CLI tool, used for Bedrock migration testing and debugging.

Now you can take the steering wheel of an ethereum execution engine, without CL, and apply cheats to the DB.

First PR in a stack of 4: base, cheats-logic, engine-logic, commands-frontend:

This PR also adds some minor additions to the op-service module, to help implement the later commands with:

  • CloseAction: to define a CLI action function that respects signals and can close a background thing gracefully.
  • ReadLocalCLIConfig variant of ReadCLIConfig for metrics and logging packages, since not all sub-commands need the metrics/logging functionality, but to share the same base functionality per sub-command where necessary.

Metadata

Fix ENG-3077

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

⚠️ No Changeset found

Latest commit: fe7509d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mslipper mslipper merged commit 20c0474 into develop Dec 7, 2022
@mslipper mslipper deleted the op-wheel-base branch December 7, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants