Skip to content

feat(indexer): Update bedrock tests for WithdrawalProven event#4281

Merged
mslipper merged 1 commit intodevelopfrom
clabby/indexer/two-step-withdrawals-tests
Dec 7, 2022
Merged

feat(indexer): Update bedrock tests for WithdrawalProven event#4281
mslipper merged 1 commit intodevelopfrom
clabby/indexer/two-step-withdrawals-tests

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Dec 7, 2022

Overview

Adds support for indexing the OptimismPortal's WithdrawalProven event added in #3836.

Tests
Updates TestBedrockIndexer in bedrock_tests.go

Metadata
ENG-3075

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

⚠️ No Changeset found

Latest commit: 2cc7625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby
Copy link
Contributor Author

clabby commented Dec 7, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify mergify bot added the A-indexer Area: indexer label Dec 7, 2022
@clabby clabby force-pushed the clabby/indexer/two-step-withdrawals-tests branch from 889674b to 2cc7625 Compare December 7, 2022 03:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #4281 (2cc7625) into clabby/indexer/two-step-withdrawals (f030d86) will increase coverage by 5.28%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##           clabby/indexer/two-step-withdrawals    #4281      +/-   ##
=======================================================================
+ Coverage                                37.63%   42.91%   +5.28%     
=======================================================================
  Files                                      168      319     +151     
  Lines                                    13092    17257    +4165     
  Branches                                     0      775     +775     
=======================================================================
+ Hits                                      4927     7406    +2479     
- Misses                                    7688     9340    +1652     
- Partials                                   477      511      +34     
Flag Coverage Δ
bedrock-go-tests 37.61% <ø> (-0.03%) ⬇️
contracts-bedrock-tests 39.57% <ø> (?)
contracts-governance-tests 83.05% <ø> (?)
contracts-periphery-tests 95.17% <ø> (?)
contracts-tests 98.86% <ø> (?)
core-utils-tests 60.41% <ø> (?)
dtl-tests 47.15% <ø> (?)
fault-detector-tests 42.17% <ø> (?)
sdk-tests 39.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/p2p/discovery.go 65.52% <0.00%> (-2.39%) ⬇️
...ts-bedrock/contracts/deployment/SystemDictator.sol 0.00% <0.00%> (ø)
packages/fault-detector/src/index.ts 100.00% <0.00%> (ø)
...tracts/contracts/L1/deployment/AddressDictator.sol 100.00% <0.00%> (ø)
packages/fault-detector/hardhat.config.ts 100.00% <0.00%> (ø)
packages/core-utils/src/external/index.ts 100.00% <0.00%> (ø)
packages/sdk/src/utils/misc-utils.ts 100.00% <0.00%> (ø)
...racts-periphery/contracts/universal/Transactor.sol 100.00% <0.00%> (ø)
...versal/op-erc721/OptimismMintableERC721Factory.sol 100.00% <0.00%> (ø)
...es/contracts-bedrock/contracts/universal/Proxy.sol 100.00% <0.00%> (ø)
... and 144 more

Base automatically changed from clabby/indexer/two-step-withdrawals to develop December 7, 2022 17:36
@mslipper mslipper merged commit 2363039 into develop Dec 7, 2022
@mslipper mslipper deleted the clabby/indexer/two-step-withdrawals-tests branch December 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants