Skip to content

feat(indexer): Support OP Portal's WithdrawalProven event#4280

Merged
mslipper merged 2 commits intodevelopfrom
clabby/indexer/two-step-withdrawals
Dec 7, 2022
Merged

feat(indexer): Support OP Portal's WithdrawalProven event#4280
mslipper merged 2 commits intodevelopfrom
clabby/indexer/two-step-withdrawals

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Dec 7, 2022

Overview

Adds support for indexing the OptimismPortal's WithdrawalProven event added in #3836.

Metadata
ENG-3075

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

🦋 Changeset detected

Latest commit: f030d86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/indexer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clabby
Copy link
Contributor Author

clabby commented Dec 7, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

Codecov Report

Merging #4280 (f030d86) into develop (c129ec6) will decrease coverage by 5.25%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4280      +/-   ##
===========================================
- Coverage    42.88%   37.63%   -5.26%     
===========================================
  Files          319      168     -151     
  Lines        17257    13092    -4165     
  Branches       775        0     -775     
===========================================
- Hits          7401     4927    -2474     
+ Misses        9342     7688    -1654     
+ Partials       514      477      -37     
Flag Coverage Δ
bedrock-go-tests 37.63% <ø> (+0.06%) ⬆️
contracts-bedrock-tests ?
contracts-governance-tests ?
contracts-periphery-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/sources/batching.go 81.25% <0.00%> (-2.68%) ⬇️
packages/core-utils/src/common/hex-strings.ts
.../contracts/L1/messaging/L1CrossDomainMessenger.sol
...ontracts/contracts/libraries/rlp/Lib_RLPReader.sol
packages/sdk/src/adapters/standard-bridge.ts
packages/sdk/tasks/index.ts
...ts-bedrock/contracts/vendor/AddressAliasHelper.sol
...ontracts-periphery/contracts/L2/L2ERC721Bridge.sol
...acts-bedrock/contracts/libraries/rlp/RLPWriter.sol
...ore-utils/src/external/ethers/fallback-provider.ts
... and 144 more

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple questions for my own understanding

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Dec 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mslipper mslipper merged commit 07ed00a into develop Dec 7, 2022
@mslipper mslipper deleted the clabby/indexer/two-step-withdrawals branch December 7, 2022 17:36
@mergify mergify bot removed the on-merge-train label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants