Test Clean Up

[maurelian]

Description

Furthers the work of reorganizing the forge tests, which was begun in #3611.

Test organizing principles

1. Uses contracts to organize the test suite similar to how mocha uses describe.
2. Every non-trivial state changing function should have a contract for happy and sad path tests. This helps to make it very obvious where there are not sad tests (I haven't added any new tests, so there are quite a few empty placeholder contracts).
3. Simpler functions like getters and setters are grouped together into test contracts.
4. All contracts and functions should be consistently named following a convention.

Test naming convention

Test function names are split by underscores, into 3 or 4 parts. An example function name is test_onlyOwner_callerIsNotOwner_reverts().

The parts are: [method]_[FunctionName]_[reason]_[success], where:

1. [method] is either test or testFuzz
2. [FunctionName] is the name of the function or higher level behavior being tested.
3. [reason] is an optional description for the behavior being tested.
4. [success] must be one of success or reverts or _fails.

Name validation

I also wrote a quick and dirty script which can be run to validate function names and identify ones which are not yet compliant. From within the bedrock package:
ts-node scripts/forges-test-names.ts.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ce6e397

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mergify]

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

[mergify]

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

[maurelian]

Closing will break up.