Initial refactor of L1StdBridge test suite#3611
Conversation
|
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Breaks the test suite up in to test contracts. Each state changing method has its own contract for happy tests and another for sad tests.
maurelian
force-pushed
the
ctb/test-cleanup
branch
2 times, most recently
from
a5e56f7 to
24f92ab
Compare
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
So the empty contracts, the idea is to fill them out later? I notice there is multiple |
Yeah, this is more of a PoC, trying to keep the diff small to get approval before I embark on this journey. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
Merge failed. Please see automated check logs for more details. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
3 participants
Description
Breaks the test suite up into distinct test contracts. Each state changing
method has its own contract for happy tests and another for sad
tests.
This is a 'weather baloon' PR with a minimal diff, affecting on the L1 Bridge.
Once accepted I'll extend the changes to the rest of the forge tests.
Tests
I added one test case to cover getters. Otherwise the only changes are renaming test methods, and breaking them up into a smaller contracts.
Having both a happy and sad test contract for each method makes it much easier to see where gaps in coverage are.
Additional context
Naming conventions were heavily inspired by Maple Finance's suite.