Skip to content

op-e2e: test op-geth pending gas limit configuration#4047

Merged
mslipper merged 3 commits intodevelopfrom
pending-gas-limit-test
Dec 16, 2022
Merged

op-e2e: test op-geth pending gas limit configuration#4047
mslipper merged 3 commits intodevelopfrom
pending-gas-limit-test

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

Description

Test the pending gas limit configurability in ethereum-optimism/op-geth#24

TODO: merge the op-geth PR first, and then update the geth references everywhere. For now I updated only the go.work for CI to run.

Tests

Test that blocks can be produced, and the verifier can pick up blocks, with consistent block gas limit that does not conflict with the local sequencer or verifier pending gas limit configurations.

Additional context

Reducing the local pending gas limit helps prevent self-DoS when the tx pool fills up and the gas limit is extremely high (e.g. the opcraft chain)

Metadata

Fix ENG-2978

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 22, 2022

⚠️ No Changeset found

Latest commit: 5fce9fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@protolambda protolambda marked this pull request as draft November 22, 2022 21:22
@protolambda
Copy link
Copy Markdown
Contributor Author

Converted this into draft. It's ready, but not that urgent. Happy thanksgiving.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 5, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Dec 5, 2022
@protolambda
Copy link
Copy Markdown
Contributor Author

Ready for review, but we'll need to update the op-geth references in go.mod files, for CI I just updated the go.work

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2022

Codecov Report

Merging #4047 (5fce9fc) into develop (13a72cb) will decrease coverage by 5.84%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4047      +/-   ##
===========================================
- Coverage    41.11%   35.26%   -5.85%     
===========================================
  Files          322      170     -152     
  Lines        17526    13357    -4169     
  Branches       784        0     -784     
===========================================
- Hits          7205     4711    -2494     
+ Misses        9808     8167    -1641     
+ Partials       513      479      -34     
Flag Coverage Δ
bedrock-go-tests 35.26% <ø> (-0.06%) ⬇️
contracts-bedrock-tests ?
contracts-periphery-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/p2p/discovery.go 65.52% <0.00%> (-2.39%) ⬇️
...ontracts/L2/predeploys/OVM_L2ToL1MessagePasser.sol
...ontracts-periphery/contracts/L1/L1ERC721Bridge.sol
packages/core-utils/src/optimism/batch-encoding.ts
packages/sdk/src/cross-chain-messenger.ts
packages/sdk/src/interfaces/types.ts
...cts/contracts/L1/deployment/ChugSplashDictator.sol
...s-bedrock/contracts/legacy/LegacyMessagePasser.sol
...ntracts-bedrock/contracts/libraries/Arithmetic.sol
...ontracts-periphery/contracts/L2/L2ERC721Bridge.sol
... and 143 more

Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with a couple of questions

@protolambda
Copy link
Copy Markdown
Contributor Author

*need to merge op-geth PR + update mod references before merging this PR.

Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@protolambda
Copy link
Copy Markdown
Contributor Author

merged op-geth PR, will update remaining geth references now for this PR to get merged with those

@protolambda protolambda requested a review from zhwrd as a code owner December 16, 2022 19:13
@protolambda
Copy link
Copy Markdown
Contributor Author

updated op-geth with make update-op-geth, and updated the update script to include the op-wheel module

@mslipper mslipper merged commit e362fc4 into develop Dec 16, 2022
@mslipper mslipper deleted the pending-gas-limit-test branch December 16, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants