Skip to content

bedrock: update op-geth dependency#3892

Merged
mslipper merged 2 commits intodevelopfrom
update-op-geth
Nov 7, 2022
Merged

bedrock: update op-geth dependency#3892
mslipper merged 2 commits intodevelopfrom
update-op-geth

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

@protolambda protolambda commented Nov 5, 2022

Description

Update op-geth dependency, rebased to latest master branch. See optimism-history branch on op-geth repo. The previous optimism-history can be found as optimism-history-nov-4 branch.

Note: the upstream miner code changed, the background job logic for updating a block specifically. Now that the first tx pool work is fully in the background the sequencer code path needs more room to breathe, or would retrieve empty blocks consistently if it asks for the block building result instantly.

This is something we can optimize later: more time is good, to build better blocks. But less time is better when we are catching up to the latest wallclock time (i.e. when we don't have as much time to wait for production).
For now I increased a few e2e tx inclusion timeouts and added some unconditional breathing time.

Other than that the trie interface changed slightly yet again, and we now use eip1559 params via the chain config.


Note: endpoint monitor and indexer were also updated from geth v1.10.23 to v1.10.26 to keep them in sync with the upstream base we use for bedrock.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 5, 2022

🦋 Changeset detected

Latest commit: a775667

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/endpoint-monitor Patch
@eth-optimism/indexer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 5, 2022
@mergify mergify bot added A-indexer Area: indexer and removed conflict labels Nov 5, 2022
@mergify mergify bot requested review from nickbalestra and roninjin10 November 5, 2022 00:55
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 5, 2022

Do you mind adding a changeset for the batch-submitter and also the monitor if its hooked up to the old docker publish flow?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 5, 2022

I think we may still have to do releases, but maybe you can delete these lines?

// temporary, until we do another set of releases
replace (
	github.com/ethereum-optimism/optimism/op-batcher v0.9.0 => ../op-batcher
	github.com/ethereum-optimism/optimism/op-proposer v0.9.0 => ../op-proposer
)

op-e2e/go.mod

@protolambda
Copy link
Copy Markdown
Contributor Author

@tynes need releases for removing those replace statements first, I still get:

go: finding module for package github.com/btcsuite/btcd/btcec
github.com/ethereum-optimism/optimism/op-e2e imports
        github.com/ethereum-optimism/optimism/op-batcher imports
        github.com/miguelmota/go-ethereum-hdwallet imports
        github.com/btcsuite/btcutil/hdkeychain imports
        github.com/btcsuite/btcd/btcec: module github.com/btcsuite/btcd@latest found (v0.23.3), but does not contain package github.com/btcsuite/btcd/btcec

pointing to the old library, instead of the new one you introduced in #3880

@mslipper mslipper merged commit f505078 into develop Nov 7, 2022
@mslipper mslipper deleted the update-op-geth branch November 7, 2022 18:48
@mslipper mslipper mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants