Skip to content

deps: replace deprecated package with updated package#3880

Merged
tynes merged 3 commits intodevelopfrom
deps/update-hdwallet
Nov 5, 2022
Merged

deps: replace deprecated package with updated package#3880
tynes merged 3 commits intodevelopfrom
deps/update-hdwallet

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Nov 4, 2022 •
edited
Loading

Description

https://github.com/miguelmota/go-ethereum-hdwallet is no longer maintained and is using older versions of dependencies. There are dependencies clashing when trying to update code elsewhere in the codebase.

https://github.com/ethereum-optimism/go-ethereum-hdwallet is a fork with updated deps such that we can more easily update other deps in the codebase and drop old deps.

Fixes ENG-2980

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51294ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Nov 4, 2022

Can you move the fork into ethereum-optimism?

@tynes tynes force-pushed the deps/update-hdwallet branch 2 times, most recently from 98edf30 to c9c4681 Compare November 4, 2022 18:28
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Nov 4, 2022

Can you move the fork into ethereum-optimism?

Updated

@tynes tynes mentioned this pull request Nov 4, 2022
Merged
trianglesphere
trianglesphere approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Let's just remember to remove the replace statements in op-e2e/go.mod when we're done.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 4, 2022
tynes added 3 commits November 4, 2022 14:45
@tynes
deps: replace deprecated package with updated package
cc4eaf7 
https://github.com/miguelmota/go-ethereum-hdwallet is no longer
maintained and is using older versions of dependencies. There are
dependencies clashing when trying to update code elsewhere in the
codebase.

https://github.com/tynes/go-ethereum-hdwallet is a fork with updated
deps such that we can more easily update other deps in the codebase
and drop old deps.
@tynes
deps: use ethereum-optimism
8152443
@tynes
deps: run make-tidy
51294ac
@tynes tynes force-pushed the deps/update-hdwallet branch from c9c4681 to 51294ac Compare November 4, 2022 21:47
@mergify mergify bot removed the conflict label Nov 4, 2022
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Nov 4, 2022

@protolambda I've rebased this PR after a recent op-node update

protolambda
protolambda approved these changes Nov 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self: Need to remove the replace statements after the op-geth PR lands.

@tynes tynes merged commit 080a437 into develop Nov 5, 2022
@tynes tynes deleted the deps/update-hdwallet branch November 5, 2022 00:42
@protolambda protolambda mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper Awaiting requested review from mslipper

2 more reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tynes @mslipper @trianglesphere @protolambda