Skip to content

merge-queue: embarking develop (6d864f4) and #3870 together#3872

Closed
mergify[bot] wants to merge 2 commits intodevelopfrom
mergify/merge-queue/e24b5075df
Closed

merge-queue: embarking develop (6d864f4) and #3870 together#3872
mergify[bot] wants to merge 2 commits intodevelopfrom
mergify/merge-queue/e24b5075df

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 3, 2022

🎉 This combination of pull requests has been checked successfully 🎉

Branch develop (6d864f4) and #3870 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3870.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

  • #approved-reviews-by>=2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • #review-threads-unresolved=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success=pr-labeler
    • check-neutral=pr-labeler
    • check-skipped=pr-labeler
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: message-relayer-tests
    • check-neutral=ci/circleci: message-relayer-tests
    • check-skipped=ci/circleci: message-relayer-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: batch-submitter-tests
    • check-neutral=ci/circleci: batch-submitter-tests
    • check-skipped=ci/circleci: batch-submitter-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: bss-core-tests
    • check-neutral=ci/circleci: bss-core-tests
    • check-skipped=ci/circleci: bss-core-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: contracts-tests
    • check-neutral=ci/circleci: contracts-tests
    • check-skipped=ci/circleci: contracts-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: core-utils-tests
    • check-neutral=ci/circleci: core-utils-tests
    • check-skipped=ci/circleci: core-utils-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: dtl-tests
    • check-neutral=ci/circleci: dtl-tests
    • check-skipped=ci/circleci: dtl-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: depcheck
    • check-neutral=ci/circleci: depcheck
    • check-skipped=ci/circleci: depcheck
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: gas-oracle-tests
    • check-neutral=ci/circleci: gas-oracle-tests
    • check-skipped=ci/circleci: gas-oracle-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: geth-tests
    • check-neutral=ci/circleci: geth-tests
    • check-skipped=ci/circleci: geth-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: indexer-tests
    • check-neutral=ci/circleci: indexer-tests
    • check-skipped=ci/circleci: indexer-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: integration-tests
    • check-neutral=ci/circleci: integration-tests
    • check-skipped=ci/circleci: integration-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: proxyd-tests
    • check-neutral=ci/circleci: proxyd-tests
    • check-skipped=ci/circleci: proxyd-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: replica-healthcheck-tests
    • check-neutral=ci/circleci: replica-healthcheck-tests
    • check-skipped=ci/circleci: replica-healthcheck-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: teleportr-tests
    • check-neutral=ci/circleci: teleportr-tests
    • check-skipped=ci/circleci: teleportr-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: yarn-monorepo
    • check-neutral=ci/circleci: yarn-monorepo
    • check-skipped=ci/circleci: yarn-monorepo
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: contracts-bedrock-tests
    • check-neutral=ci/circleci: contracts-bedrock-tests
    • check-skipped=ci/circleci: contracts-bedrock-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: contracts-governance-tests
    • check-neutral=ci/circleci: contracts-governance-tests
    • check-skipped=ci/circleci: contracts-governance-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: contracts-periphery-tests
    • check-neutral=ci/circleci: contracts-periphery-tests
    • check-skipped=ci/circleci: contracts-periphery-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: bedrock-go-tests
    • check-neutral=ci/circleci: bedrock-go-tests
    • check-skipped=ci/circleci: bedrock-go-tests
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: op-bindings-build
    • check-neutral=ci/circleci: op-bindings-build
    • check-skipped=ci/circleci: op-bindings-build
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: hive-test-l1ops
    • check-neutral=ci/circleci: hive-test-l1ops
    • check-skipped=ci/circleci: hive-test-l1ops
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: hive-test-p2p
    • check-neutral=ci/circleci: hive-test-p2p
    • check-skipped=ci/circleci: hive-test-p2p
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: hive-test-rpc
    • check-neutral=ci/circleci: hive-test-rpc
    • check-skipped=ci/circleci: hive-test-rpc
  • any of [🛡 GitHub branch protection]:
    • check-success=ci/circleci: devnet (with genesis contracts)
    • check-neutral=ci/circleci: devnet (with genesis contracts)
    • check-skipped=ci/circleci: devnet (with genesis contracts)
  • any of [🛡 GitHub branch protection]:
    • check-success=security/snyk (Optimism)
    • check-neutral=security/snyk (Optimism)
    • check-skipped=security/snyk (Optimism)

More informations about Mergify merge queue can be found in the documentation.

Mergify commands

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the queue rules

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

---
pull_requests:
  - number: 3870
...

tynes and others added 2 commits November 3, 2022 12:32
Includes ethereum-optimism/op-geth#23

Pulling these changes into the monorepo so that things can be
integrated with `op-e2e`
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2022

⚠️ No Changeset found

Latest commit: b55537a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #3872 (b55537a) into develop (6d864f4) will decrease coverage by 1.71%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3872      +/-   ##
===========================================
- Coverage    57.67%   55.95%   -1.72%     
===========================================
  Files          347      246     -101     
  Lines        19075    16754    -2321     
  Branches       765      387     -378     
===========================================
- Hits         11001     9375    -1626     
+ Misses        7170     6506     -664     
+ Partials       904      873      -31     
Flag Coverage Δ
bedrock-go-tests 56.67% <ø> (+0.20%) ⬆️
contracts-bedrock-tests ?
contracts-governance-tests 83.05% <ø> (ø)
contracts-periphery-tests 96.49% <ø> (ø)
contracts-tests ?
core-utils-tests ?
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.62% <ø> (ø)
sdk-tests 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-proposer/service.go 91.02% <0.00%> (ø)
...racts-bedrock/contracts/L2/L2ToL1MessagePasser.sol
...ontracts/contracts/libraries/rlp/Lib_RLPWriter.sol
.../contracts/libraries/trie/Lib_SecureMerkleTrie.sol
...acts-bedrock/contracts/libraries/rlp/RLPReader.sol
packages/core-utils/src/external/index.ts
...es/contracts-bedrock/contracts/libraries/Bytes.sol
...cts-bedrock/contracts/legacy/L1ChugSplashProxy.sol
...es/contracts-bedrock/contracts/universal/Proxy.sol
...cts/contracts/L1/deployment/ChugSplashDictator.sol
... and 101 more

@mergify
Copy link
Contributor Author

mergify bot commented Nov 3, 2022

The pull request #3870 is mergeable

@mergify mergify bot closed this Nov 3, 2022
@mergify mergify bot deleted the mergify/merge-queue/e24b5075df branch November 3, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants