Action-testing: extend user actor with withdrawal txs#3670
Action-testing: extend user actor with withdrawal txs#3670mergify[bot] merged 2 commits intodevelopfrom
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Will rebase this onto the proposer work so we can change it from draft to ready |
252ae24 to
33ae5d4
Compare
|
Rebased onto |
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
33ae5d4 to
af12f2d
Compare
trianglesphere
left a comment
There was a problem hiding this comment.
PR description still doesn't mention the refactoring in here.
|
@trianglesphere updated, thanks |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Withdrawals depend on the proposer working in action-testing. So this is now split from the main user-actor PR (#3628) to integrate with the proposer actor.
Update the withdrawals RPC client input to use minimal interfaces, and refactor to not tightly couple geth and eth client functionality. This enables the use of an instrumented
client.RPCand mocks.Depends on #3628Depends on #3805Tests
Test creates a withdrawal tx on L2, includes it, then makes proposal on L1 for the L2 blocks including the withdrawal, includes those on L1, checks the withdrawal period, and then completes the withdrawal.
Fix ENG-2763