Skip to content

Action-testing: extend user actor with withdrawal txs#3670

Merged
mergify[bot] merged 2 commits intodevelopfrom
action-testing-user-withdrawal
Nov 3, 2022
Merged

Action-testing: extend user actor with withdrawal txs#3670
mergify[bot] merged 2 commits intodevelopfrom
action-testing-user-withdrawal

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented Oct 7, 2022

Description

Withdrawals depend on the proposer working in action-testing. So this is now split from the main user-actor PR (#3628) to integrate with the proposer actor.

Update the withdrawals RPC client input to use minimal interfaces, and refactor to not tightly couple geth and eth client functionality. This enables the use of an instrumented client.RPC and mocks.

Depends on #3628

Depends on #3805

Tests

Test creates a withdrawal tx on L2, includes it, then makes proposal on L1 for the L2 blocks including the withdrawal, includes those on L1, checks the withdrawal period, and then completes the withdrawal.

Fix ENG-2763

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

⚠️ No Changeset found

Latest commit: b05345d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@protolambda protolambda changed the base branch from develop to action-testing-user October 7, 2022 05:01
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Base automatically changed from action-testing-user to develop October 13, 2022 23:00
@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@protolambda
Copy link
Contributor Author

Will rebase this onto the proposer work so we can change it from draft to ready

@protolambda protolambda force-pushed the action-testing-user-withdrawal branch from 252ae24 to 33ae5d4 Compare November 1, 2022 13:29
@mergify mergify bot added the A-indexer Area: indexer label Nov 1, 2022
@mergify mergify bot requested review from nickbalestra and roninjin10 November 1, 2022 13:30
@protolambda protolambda changed the base branch from develop to proposer-cleanup November 1, 2022 13:31
@protolambda
Copy link
Contributor Author

Rebased onto proposer-cleanup (#3805), we can now test withdrawals once the proposer actor makes its output root proposals.

@protolambda protolambda marked this pull request as ready for review November 1, 2022 13:34
Base automatically changed from proposer-cleanup to develop November 2, 2022 17:53
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 2, 2022
@protolambda protolambda force-pushed the action-testing-user-withdrawal branch from 33ae5d4 to af12f2d Compare November 2, 2022 19:01
@mergify mergify bot removed the conflict label Nov 2, 2022
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description still doesn't mention the refactoring in here.

@protolambda
Copy link
Contributor Author

@trianglesphere updated, thanks

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Nov 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 6d864f4 into develop Nov 3, 2022
@mergify mergify bot deleted the action-testing-user-withdrawal branch November 3, 2022 20:27
@mergify mergify bot removed the on-merge-train label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants