Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
… not calling the legacy start/complete combination
bfe6c49 to
c3455d3
Compare
trianglesphere
left a comment
There was a problem hiding this comment.
This is a cool framework, but having more comments would be really helpful for understanding the actions.
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
This PR introduces:
L1BindingsandL2Bindings: contracts backed by an ethclient and other typed client bindings for users.BasicUserEnvwhich holds common user environment properties (i.e. can be shared between users). This is using generics, so we can embed either L1 or L2 bindings.BasicUseractor that can make txs and randomize their tx input choices with actions.CrossLayerUseractor that has a L1 and L2BasicUserside and combines them to enable deposits and later withdrawal actions (see Action-testing: extend user actor with withdrawal txs #3670).Some of the actions to randomize and create tx contents are still a bit unpolished; we can fix that when when we use the User actor in more tests.
This also fixes minor bugs in action-testing:
Tests
Create
aliceand make all types of transactions in very few lines of code: these actions can be reordered/repeated to build different L1/L2 chains (and we can do so with more users too).Additional context
Some of the action functions are curried so we can make an action with the same parameters that is repeatable.
Metadata
Fix ENG-2765