op-e2e: Migrate tests to op-chain-ops#3650
op-e2e: Migrate tests to op-chain-ops#3650mslipper wants to merge 1 commit into10-04-op-e2e_Start_adopting_op-chain-opsfrom
Conversation
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| L1StandardBridgeProxy: predeploys.DevL1StandardBridgeAddr, | ||
| L1CrossDomainMessengerProxy: predeploys.DevL1CrossDomainMessengerAddr, | ||
| } | ||
| l2Genesis, err := genesis.BuildL2DeveloperGenesis(cfg.DeployConfig, l1Block, l2Addrs) |
There was a problem hiding this comment.
Curious what you think here, once #3644 is merged then you can pass nil for l2Addrs and the dev values will be used. I think this is useful because this struct might need to be updated and it'll let us delete the same boilerplate in many places
| // Tally L2 Fee | ||
| l2Fee := gasTip.Mul(gasTip, new(big.Int).SetUint64(receipt.GasUsed)) | ||
| require.Equal(t, l2Fee, coinbaseDiff, "l2 fee mismatch") | ||
| //l2Fee := gasTip.Mul(gasTip, new(big.Int).SetUint64(receipt.GasUsed)) |
|
Closing in favor of #3649, which I folded this into. |
3 participants
This PR actually performs the migration of all the op-e2e tests to the op-chain-ops suite of libraries.