op-e2e: Adopt op-chain-ops

[mslipper]

This PR updates op-e2e to use op-chain-ops. Adopting op-chain-ops in op-e2e improves the following:

1. Transactions now route through the correct proxy contracts.
2. There's no need to wait for a contract deployment since conracts exist in genesis.
3. We can export the test helpers in op-e2e to enable us to run similar end-to-end tests in other applications like the indexer

[changeset-bot]

⚠️ No Changeset found

Latest commit: caf72b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mslipper]

Current dependencies on/for this PR:

• develop
  • PR op-e2e: Adopt op-chain-ops #3649 👈
    • PR op-e2e: Migrate tests to op-chain-ops #3650

This comment was auto-generated by Graphite.

[mergify]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

[trianglesphere]

@mslipper I think the secrets have already been ported over to the e2eutils folder: https://github.com/ethereum-optimism/optimism/blob/develop/op-e2e/e2eutils/secrets.go

[mslipper]

I rolled #3650 in here since the secrets util was already included - will push once tests pass locally.

[mslipper]

Removing dead code made this a hair over PR size SLA.

[tynes]

being able to adopt this code and have it used as the test infra is nice, gives more confidence in using it for the actual state surgery

[trianglesphere]

2 small things, but I'm excited for this

[tynes]

I'd like to get this merged so I can use it to write better tests for #3528
Realizing that the tests that I'd like to write belong more in op-e2e than in op-chain-ops

[mslipper]

I'm debugging a test timeout. Stand by.

[mslipper]

Ok, this one was really interesting - the timeout was caused by a deadlock in the SyncStatus function. Here's the implementation:

func (s *state) SyncStatus(ctx context.Context) (*eth.SyncStatus, error) {
	respCh := make(chan eth.SyncStatus)
	select {
	case <-ctx.Done():
		return nil, ctx.Err()
	case s.syncStatusReq <- respCh:
		select {
		case <-ctx.Done():
			return nil, ctx.Err()
		case resp := <-respCh:
			return &resp, nil
		}
	}
}

In some cases, the e2e test would cancel the passed-in context. This caused the function to return. If the timing as correct, the context would be canceled before the driver loop had a chance to send a response to respCh. This caused closing the rollup node to hang, since the listener for the done channel in Close() is inside the big driver loop.

The solution was to make respCh buffered, so that the driver can still send responses to the channel after the SyncStatus context is closed.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.