Skip to content

op-e2e: Action testing L1 replica + miner code (combined by mergify)#3601

Merged
mergify[bot] merged 3 commits intodevelopfrom
action-l1-replica
Sep 29, 2022
Merged

op-e2e: Action testing L1 replica + miner code (combined by mergify)#3601
mergify[bot] merged 3 commits intodevelopfrom
action-l1-replica

Conversation

@protolambda
Copy link
Contributor

Description

Depends on #3599 and #3600 (will rebase out the commits / diff once those PRs are merged)

Implements L1 replica actor for action testing, with actions to fake RPC errors, ewind it, and reorg to some arbitrary canonical chain.
The L1 miner actor will wrap this, and build actual blocks with actions.
The L1 miner and replica(s) will then serve the L2 rollup nodes and user actors in action testing.

Tests

  • Basic test of the replica reorg functionality without L1 miner, by generating an artificial chain, although it's more clumsy than when we get the L1 miner actions to build blocks.
  • Basic test of the replica RPC error faking

Metadata

Fix ENG-2760

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: afec777

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot removed the conflict label Sep 29, 2022
@protolambda protolambda changed the title Action l1 replica op-e2e: Action testing L1 replica Sep 29, 2022
Base automatically changed from rpc-err-faker to develop September 29, 2022 14:17
@trianglesphere
Copy link
Contributor

github changed the base, but does this need a rebase @protolambda?

@protolambda
Copy link
Contributor Author

Yes, will rebase. Annoying that the squash of the dependencies messes it up

@protolambda protolambda force-pushed the action-l1-replica branch 2 times, most recently from 84c16da to e1a26e6 Compare September 29, 2022 16:22
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. I've got a small questions, but this is looking good.

@trianglesphere
Copy link
Contributor

oops, the next stacked PR got automerged into this one

@protolambda protolambda changed the title op-e2e: Action testing L1 replica op-e2e: Action testing L1 replica + miner code (combined by mergify) Sep 29, 2022
@protolambda
Copy link
Contributor Author

rebasing this on top of develop

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 4cfcd89 into develop Sep 29, 2022
@mergify mergify bot deleted the action-l1-replica branch September 29, 2022 19:27
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 29, 2022
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants