Skip to content

op-node: testlog now uses interface, to swap testing backend easily#3600

Merged
mergify[bot] merged 2 commits intodevelopfrom
testlog-iface
Sep 29, 2022
Merged

op-node: testlog now uses interface, to swap testing backend easily#3600
mergify[bot] merged 2 commits intodevelopfrom
testlog-iface

Conversation

@protolambda
Copy link
Contributor

To instantiate test loggers as part of action testing, Hive testing, etc. we should hide the testing backend with an interface.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: fd80f81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit aeb8125 into develop Sep 29, 2022
@mergify mergify bot deleted the testlog-iface branch September 29, 2022 14:26
@mergify mergify bot removed the on-merge-train label Sep 29, 2022
This was referenced Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants