contracts-bedrock: fix gas estimation for deposits#3589
Closed
contracts-bedrock: fix gas estimation for deposits#3589
Conversation
|
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
protolambda
reviewed
Sep 28, 2022
| // Give the user a refund based on the amount of gas they used to do all of the work up to | ||
| // this point. Since we're at the end of the modifier, this should be pretty accurate. Acts | ||
| // effectively like a dynamic stipend (with a minimum value). | ||
| uint256 usedGas = initialGas - gasleft(); |
Contributor
There was a problem hiding this comment.
Now the blockDiff > 0 code doesn't count toward the usedGas for the burn anymore, the burn should be after that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lets see if this fixes the gas estimation problems in
l1opshive