Attempt to fix deposit/withdrawal tests#48
Merged
Conversation
I narrowed this issue down to reverts during deposits. It seems like the default gas limit calculation under-estimates the limit sometimes which leads to deposits reverting without a reason. I'm not 100% sure why this is, but I have a hunch it's related to the `ResourceMetering` contract since specifying a high manual gas limit resolved the issue. I'll follow up with @tynes to dig deeper into whether this is correct, and understand the root cause. To test this, I ran the tests 3 times against CI and got passes each time. Fixes ENG-2726
protolambda
approved these changes
Sep 28, 2022
|
This is a bandaid, attempted real solution here: ethereum-optimism/optimism#3589 |
tynes
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I narrowed this issue down to reverts during deposits. It seems like the default gas limit calculation under-estimates the limit sometimes which leads to deposits reverting without a reason. I'm not 100% sure why this is, but I have a hunch it's related to the
ResourceMeteringcontract since specifying a high manual gas limit resolved the issue. I'll follow up with @tynes to dig deeper into whether this is correct, and understand the root cause.To test this, I ran the tests 3 times against CI and got passes each time.
I also updated the
WaitReceipthelper to properly check the status of each transaction.Fixes ENG-2726