Skip to content

fix: simplify erc20 factory#3370

Closed
tynes wants to merge 12 commits intodevelopfrom
fix/simplify-erc20-factory
Closed

fix: simplify erc20 factory#3370
tynes wants to merge 12 commits intodevelopfrom
fix/simplify-erc20-factory

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Sep 9, 2022

Description

Updates the OptimismMintableERC20Factory to have an L1 and L2 version. This simplifies the system
as the L2 contract can have a hardcoded predeploy value for the bridge and the L1 version can be deployed
with the deployed address of the L1 bridge

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

⚠️ No Changeset found

Latest commit: a074e7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Sep 9, 2022
@tynes tynes force-pushed the fix/simplify-erc20-factory branch from 08404fb to c0ff2af Compare September 9, 2022 12:46
@tynes tynes mentioned this pull request Sep 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 10, 2022
@mergify mergify bot removed the conflict label Sep 20, 2022
@mslipper
Copy link
Contributor

I updated the bindings - still seeing a bunch of failing tests. Looks like op-chain-ops and the sdk haven't been completely migrated over to use the new contracts.

Copy link
Contributor

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 21, 2022
@mslipper mslipper closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants