Skip to content

fix: simplify erc20 factory #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tynes wants to merge 12 commits into from
Closed

fix: simplify erc20 factory #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1e91825
op-bindings: regenerate
tynes Sep 9, 2022
5f6450f
op-bindings: update predeploy names
tynes Sep 9, 2022
9e0f632
op-bindings: update makefile
tynes Sep 9, 2022
2bd8407
op-chain-ops: simplify erc20 factory setup
tynes Sep 9, 2022
2021c2c
contracts-bedrock: split up erc20 factory for L1 + L2
tynes Sep 9, 2022
fe671e2
specs: update
tynes Sep 9, 2022
c0ff2af
fix: dev addresses
tynes Sep 9, 2022
a1b2559
op-chain-ops: re-add L2OptimismMintableERC20Factory
tynes Sep 9, 2022
0b19657
contracts-bedrock: fix natspec
tynes Sep 9, 2022
1333e5c
Merge remote-tracking branch 'upstream/develop' into fix/simplify-erc…
mslipper Sep 20, 2022
a08ff3a
remove orig
mslipper Sep 20, 2022
a074e7e
chore: update bindings
mslipper Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions op-bindings/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ SHELL := /bin/bash

pkg := bindings

all: version mkdir bindings more
all: version mkdir bindings more cleanup-tmp

bindings: l1block-bindings \
l1-cross-domain-messenger-bindings \
Expand All @@ -15,7 +15,8 @@ bindings: l1block-bindings \
l2-cross-domain-messenger-bindings \
l2-standard-bridge-bindings \
sequencer-fee-vault-bindings \
optimism-mintable-erc20-factory-bindings \
l1-optimism-mintable-erc20-factory-bindings \
l2-optimism-mintable-erc20-factory-bindings \
optimism-mintable-erc20-bindings \
proxy-bindings \
proxy-admin-bindings \
Expand All @@ -31,6 +32,9 @@ compile:
yarn clean && \
npx hardhat compile

cleanup-tmp:
cd ../packages/contracts-bedrock && rm -rf tmp-artifacts

l1-cross-domain-messenger-bindings: compile
./gen_bindings.sh contracts/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger $(pkg)

Expand Down Expand Up @@ -64,8 +68,11 @@ l2-standard-bridge-bindings: compile
sequencer-fee-vault-bindings: compile
./gen_bindings.sh contracts/L2/SequencerFeeVault.sol:SequencerFeeVault $(pkg)

optimism-mintable-erc20-factory-bindings: compile
./gen_bindings.sh contracts/universal/OptimismMintableERC20Factory.sol:OptimismMintableERC20Factory $(pkg)
l1-optimism-mintable-erc20-factory-bindings: compile
./gen_bindings.sh contracts/L1/L1OptimismMintableERC20Factory.sol:L1OptimismMintableERC20Factory $(pkg)

l2-optimism-mintable-erc20-factory-bindings: compile
./gen_bindings.sh contracts/L2/L2OptimismMintableERC20Factory.sol:L2OptimismMintableERC20Factory $(pkg)

optimism-mintable-erc20-bindings: compile
./gen_bindings.sh contracts/universal/OptimismMintableERC20.sol:OptimismMintableERC20 $(pkg)
Expand All @@ -92,7 +99,7 @@ more:
go run ./gen/main.go \
-artifacts ../packages/contracts-bedrock/artifacts \
-out ./bindings \
-contracts OptimismMintableERC20Factory,L2StandardBridge,L1BlockNumber,DeployerWhitelist,Proxy,OptimismPortal,L2ToL1MessagePasser,L2CrossDomainMessenger,GasPriceOracle,SequencerFeeVault,L1Block,LegacyERC20ETH,WETH9,GovernanceToken,L1CrossDomainMessenger \
-contracts L2OptimismMintableERC20Factory,L2StandardBridge,L1BlockNumber,DeployerWhitelist,Proxy,OptimismPortal,L2ToL1MessagePasser,L2CrossDomainMessenger,GasPriceOracle,SequencerFeeVault,L1Block,LegacyERC20ETH,WETH9,GovernanceToken,L1CrossDomainMessenger \
-package bindings

mkdir:
Expand Down
2 changes: 1 addition & 1 deletion op-bindings/bindings/deployerwhitelist_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion op-bindings/bindings/gaspriceoracle_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion op-bindings/bindings/governancetoken_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion op-bindings/bindings/l1block_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading