You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reorgs happened (on L1 Goerli testnet, 20+ block deep, well past confirmation distance)
Frame from data tx was missed again (twice actually). Due to valid reasons: it was just too old, from pre-reorg multiple minutes ago, likely bad L1 data in there too.
Batches after that frame were still derived, and not dropped, and insertion into engine was attempted
Nonce errors were hit, but this time we hit a different error path: we received back an RPC error code that we were not properly handling. So the nice payload-attributes validity error we got was assumed to be temporary.
And then it got stuck retrying those attributes over and over again. At least we have a backoff, but it essentially got stuck due to bad error handling
Transforms the RPC error into an InputError so we can safely wrap it without losing the ability to distinguish errors
Handles forkchoice-update errors pre-block-insertion as a reason to reset to regain consistency, not a reason to drop sequencer transactions to try to force forward when the forkchoice is incoherent already.
Handles input-errors: transactions can be bad, and the payload processing status may not be reached if something is wrong about the input before EVM execution. Nonce values are one example of this.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testnet bugfix:
This PR:
InputErrorso we can safely wrap it without losing the ability to distinguish errorsDepends on #3318 for lint issue in CI.
Metadata
Fix ENG-2695