Conversation
The build was missed someplace and is now breaking ci everywhere
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Jul 26, 2022
maurelian
pushed a commit
that referenced
this pull request
Jul 26, 2022
* op-bindings: regenerate The build was missed someplace and is now breaking ci everywhere * ci: build monorepo with op-bindings change
Merged
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-bindings: regenerate The build was missed someplace and is now breaking ci everywhere * ci: build monorepo with op-bindings change
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-bindings: regenerate The build was missed someplace and is now breaking ci everywhere * ci: build monorepo with op-bindings change
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
The denominator zero check in `decode_holocene_eip_1559_params_block_header` and `decode_jovian_eip_1559_params_block_header` was returning `EIP1559ParamError::ElasticityOverflow` which doesn't make sense - we're checking the denominator, not elasticity. Introduced `Eip1559ValidationError` inner type with: - `ZeroDenominator` - for the zero denominator case - `Decode(EIP1559ParamError)` - wrapping upstream decoding errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build was missed someplace and is now breaking ci everywhere