Skip to content

contracts-bedrock: update hardhat forge dep#3095

Merged
tynes merged 4 commits intodevelopfrom
deps/contracts-bedrock
Jul 28, 2022
Merged

contracts-bedrock: update hardhat forge dep#3095
tynes merged 4 commits intodevelopfrom
deps/contracts-bedrock

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jul 25, 2022

Description
Updates hardhat forge plugin (should fix etherscan verify) and also delete some dead deps

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

🦋 Changeset detected

Latest commit: a057342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 25, 2022
@maurelian
Copy link
Contributor

Any idea why this modifies the L2OutputOracle bindings?

@tynes
Copy link
Contributor Author

tynes commented Jul 26, 2022

I'm pretty sure that the altered bindings are from a different PR that was not caught in CI

@tynes
Copy link
Contributor Author

tynes commented Jul 26, 2022

I'm pretty sure that the altered bindings are from a different PR that was not caught in CI

Fixed in #3099

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 26, 2022
@tynes tynes force-pushed the deps/contracts-bedrock branch from 1ad0190 to 6cc63d6 Compare July 28, 2022 00:56
@mergify mergify bot removed the conflict label Jul 28, 2022
@tynes tynes requested a review from maurelian July 28, 2022 16:43
@tynes tynes merged commit 1242293 into develop Jul 28, 2022
@tynes tynes deleted the deps/contracts-bedrock branch July 28, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants