Skip to content

fix: remove deposit tx subtype#3036

Merged
mergify[bot] merged 3 commits intodevelopfrom
fix/remove-deposit-tx-subtype
Jul 16, 2022
Merged

fix: remove deposit tx subtype#3036
mergify[bot] merged 3 commits intodevelopfrom
fix/remove-deposit-tx-subtype

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jul 14, 2022

Description

Opt to stay typed tx spec compliant

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: 105b740

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/core-utils Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 15, 2022
@protolambda protolambda force-pushed the fix/remove-deposit-tx-subtype branch from 8707f5e to 9eb424a Compare July 16, 2022 00:11
@mergify mergify bot removed the conflict label Jul 16, 2022
@protolambda
Copy link
Contributor

  • rebased onto develop
  • introduce the geth changes for deposit tx type sub-version removal
  • our geth diff is now rebased onto latest master upstream
    • full commit history on the optimism-history branch
    • in monorepo we pull in the optimism-prototype branch as dependency (cleaned up commit order, and fixed several minor issues with latest rebase to master)

@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 8d26459 into develop Jul 16, 2022
@mergify mergify bot deleted the fix/remove-deposit-tx-subtype branch July 16, 2022 00:35
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 16, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants