This repository was archived by the owner on Aug 20, 2022. It is now read-only.
core: remove deposit-tx sub-type (a.k.a. deposit version byte)#33
Merged
protolambda merged 1 commit intooptimism-prototypefrom Jul 15, 2022
Merged
core: remove deposit-tx sub-type (a.k.a. deposit version byte)#33protolambda merged 1 commit intooptimism-prototypefrom
protolambda merged 1 commit intooptimism-prototypefrom
Conversation
trianglesphere
approved these changes
Jul 13, 2022
|
PR in the monorepo: ethereum-optimism/optimism#3036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the deposit tx sub-byte, in favor of reduced diff, higher compatibility with the expectation of 1 byte + RLP, and no RPC/receipt/tx changes.
If we have to extend the deposit tx with new data we can do so either by adding an optional RLP field, or with a new regular tx type. And deposit behavior can already be hardforked by modifying the rollup-node that creates the tx, or hardforking the geth processing code.