Skip to content

ci: updates version of bash in ci-builder#3007

Merged
mergify[bot] merged 1 commit intodevelopfrom
fix/ci-builder-bash
Jul 13, 2022
Merged

ci: updates version of bash in ci-builder#3007
mergify[bot] merged 1 commit intodevelopfrom
fix/ci-builder-bash

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jul 13, 2022

Also deletes leftover copies of solc in the
root of the image. They are copied to the places
where they are expected.

Description
Updates bash in the ci-builder image, this seems to fix problems with vm.ffi in #2980. That PR works on my machine locally and I rebuilt this docker image locally and ran the tests in it and they all passed. In the existing ci-builder, the differential tests fail for some reason.

Will need to trigger a release of ci-builder

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: f1d8367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/ci-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Also deletes leftover copies of solc in the
root of the image. They are copied to the places
where they are expected.
@tynes tynes force-pushed the fix/ci-builder-bash branch from 177c5cc to f1d8367 Compare July 13, 2022 01:48
@tynes tynes requested a review from optimisticben July 13, 2022 02:22
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit a60502f into develop Jul 13, 2022
@mergify mergify bot deleted the fix/ci-builder-bash branch July 13, 2022 12:20
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants