Skip to content

contracts-bedrock: differential fuzzing#2980

Merged
mergify[bot] merged 7 commits intodevelopfrom
tynes/differential-testing-start
Jul 19, 2022
Merged

contracts-bedrock: differential fuzzing#2980
mergify[bot] merged 7 commits intodevelopfrom
tynes/differential-testing-start

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jul 11, 2022

Description
Begin more thorough testing of withdrawals by starting with some differential fuzzing of versioned encodings and versioned hashes. The config was updated with ffi = true so that the vm.ffi cheatcode can be used.

The version of forge-std was also updated so that the vm.toString cheatcodes could be used.

The encodings/hashing lib was implemented in core-utils

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 3d02c01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@eth-optimism/core-utils Patch
@eth-optimism/contracts-bedrock Patch
@eth-optimism/contracts-periphery Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-op-bindings Area: op-bindings A-pkg-core-utils Area: packages/core-utils labels Jul 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 12, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from e49aec6 to 7682338 Compare July 12, 2022 22:23
@mergify mergify bot removed the conflict label Jul 12, 2022
@tynes
Copy link
Contributor Author

tynes commented Jul 13, 2022 •
edited
Loading

These tests fail on nodejs v16 but pass on nodejs 14. There must have been a change with std? Investigating more. The ci builder uses 16

The problem was an old version of bash in the ci-builder image

@tynes tynes mentioned this pull request Jul 13, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from 6cf8f7f to c39d8a3 Compare July 13, 2022 20:07
@mergify mergify bot removed the conflict label Jul 13, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from c39d8a3 to d7efc3a Compare July 13, 2022 20:35
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from d7efc3a to 913fb4f Compare July 13, 2022 20:46
@mergify mergify bot removed the conflict label Jul 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added conflict and removed conflict labels Jul 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from 981cc22 to 67bf836 Compare July 14, 2022 15:31
@mergify mergify bot removed the conflict label Jul 14, 2022
maurelian
maurelian reviewed Jul 14, 2022
View reviewed changes
maurelian
maurelian reviewed Jul 14, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 15, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from 54ea70c to 9c67666 Compare July 16, 2022 17:42
@mergify mergify bot removed the conflict label Jul 16, 2022
@tynes
Copy link
Contributor Author

tynes commented Jul 16, 2022

I rebased this PR and got the differential fuzzing of withdrawals covered. It uses ethereumjs packages to create pmt proofs. CI is configured to run 512 fuzz runs

@tynes tynes changed the title contracts-bedrock: differential fuzzing start contracts-bedrock: differential fuzzing Jul 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 17, 2022
@tynes tynes force-pushed the tynes/differential-testing-start branch from 9c67666 to 362b239 Compare July 18, 2022 13:14
@mergify mergify bot removed the conflict label Jul 18, 2022
maurelian
maurelian reviewed Jul 18, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 0bf3b9b into develop Jul 19, 2022
@mergify mergify bot deleted the tynes/differential-testing-start branch July 19, 2022 10:13
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-op-bindings Area: op-bindings A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @smartcontracts @maurelian