Skip to content

feat(ctb): include Semver version function#2997

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/ctb-semver-version
Jul 15, 2022
Merged

feat(ctb): include Semver version function#2997
mergify[bot] merged 2 commits intodevelopfrom
sc/ctb-semver-version

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Jul 12, 2022

Description
Updates the Semver contract to include a getter function to retrieve the
full version string.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 177e01f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smartcontracts smartcontracts requested review from maurelian and tynes and removed request for maurelian July 12, 2022 19:44
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 12, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from d785a85 to e30aa92 Compare July 12, 2022 20:01
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch 2 times, most recently from b0b64c1 to f937cba Compare July 13, 2022 15:32
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from f937cba to 4d66e33 Compare July 13, 2022 17:47
@mergify mergify bot removed the conflict label Jul 13, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from 4d66e33 to fd0aff6 Compare July 13, 2022 19:47
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from fd0aff6 to 9e4c71e Compare July 13, 2022 21:10
@mergify mergify bot removed the conflict label Jul 13, 2022
@tynes
Copy link
Contributor

tynes commented Jul 13, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from 9e4c71e to 755aed8 Compare July 13, 2022 22:07
@mergify mergify bot removed the conflict label Jul 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@tynes tynes force-pushed the sc/ctb-semver-version branch from 3667024 to a32ff01 Compare July 14, 2022 00:18
@mergify mergify bot removed the conflict label Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from a32ff01 to df6f761 Compare July 14, 2022 15:29
@mergify mergify bot removed the conflict label Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from df6f761 to c7326cf Compare July 14, 2022 19:32
@mergify mergify bot removed the conflict label Jul 14, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from c7326cf to f34e00f Compare July 14, 2022 21:01
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from f34e00f to 66d7ba0 Compare July 15, 2022 15:15
@mergify mergify bot removed the conflict label Jul 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 15, 2022
@smartcontracts
feat(ctb): include Semver version function
40900b2 
Updates the Semver contract to include a getter function to retrieve the
full version string.
@smartcontracts smartcontracts force-pushed the sc/ctb-semver-version branch from 66d7ba0 to 40900b2 Compare July 15, 2022 15:31
@mergify mergify bot removed the conflict label Jul 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 5de373e into develop Jul 15, 2022
@mergify mergify bot deleted the sc/ctb-semver-version branch July 15, 2022 16:03
@mergify mergify bot removed the on-merge-train label Jul 15, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@einar-oplabs
perf(ci/tests): parallelize action-tests (#2997)
92811cd 
Resolves #2983 

Warnings about missing cache keys are expect outside of `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartcontracts @tynes @maurelian