Skip to content

style(ctb): clean up hashing and encoding libs#2983

Merged
mergify[bot] merged 4 commits intodevelopfrom
sc/ctb-clean-hash-enc
Jul 12, 2022
Merged

style(ctb): clean up hashing and encoding libs#2983
mergify[bot] merged 4 commits intodevelopfrom
sc/ctb-clean-hash-enc

Conversation

@smartcontracts
Copy link
Contributor

Description
Cleans up Hashing and Encoding libraries. Updates natspec and cleans up
function names.

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

🦋 Changeset detected

Latest commit: 6eaede8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 11, 2022
Cleans up Hashing and Encoding libraries. Updates natspec and cleans up
function names.
@smartcontracts smartcontracts force-pushed the sc/ctb-clean-hash-enc branch from 28978e4 to 70bc269 Compare July 12, 2022 00:11
@tynes
Copy link
Contributor

tynes commented Jul 12, 2022

Not directly related to this PR, but these values get passed around together all the time. WDYT on putting them into a struct and treating them as a proper type?

Going to resolve this convo for now so this can get merged and then can handle this in a follow up PR

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 28bd76a into develop Jul 12, 2022
@mergify mergify bot deleted the sc/ctb-clean-hash-enc branch July 12, 2022 17:42
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 12, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Resolves #2983 

Warnings about missing cache keys are expect outside of `main`.
theochap pushed a commit that referenced this pull request Jan 14, 2026
Resolves #2983 

Warnings about missing cache keys are expect outside of `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants