make: Misc Makefile Improvements#2772
Merged
mergify[bot] merged 2 commits intodevelopfrom Jun 14, 2022
Merged
Conversation
* Add `make nuke` which removes ALL build output/caches/etc (everything that is `.gitignore`d). * Add `-v` flag to `xargs` in `make devnet-clean` so that it doesn't error when there are no volumes or images to delete. * If `nvm` is installed, emit `nvm use` before compiling js. * Add `yarn install` to `build-ts`.
|
mslipper
approved these changes
Jun 14, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Closes #2771 Spec: ethereum-optimism/specs#753 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make nukewhich removes ALL build output/caches/etc (everything that is.gitignored)cleananddevnet-cleanas dependencies-vflag toxargsinmake devnet-cleanso that it doesn't error when there are no volumes or images to deletenvmis installed, emitnvm useto switch to the.nvmrcversion before compiling jsyarn installtobuild-ts: it doesn't add much overhead, and avoids confusion when dummies like me forget to run it beforehand (there is really nothing in the subsequent error message that tells you that this is what is going on)