Skip to content

Comments

(WIP) derive: Implement BatchQueue with full window#2771

Merged
protolambda merged 2 commits intobatch-deriv-v2from
jg/simple_batch_derivation
Jun 14, 2022
Merged

(WIP) derive: Implement BatchQueue with full window#2771
protolambda merged 2 commits intobatch-deriv-v2from
jg/simple_batch_derivation

Conversation

@trianglesphere
Copy link
Contributor

This implements a simple algorithm for the batch queue. It waits
until it has a full sequence window and then runs the historical
batch derivation process over that data.

The WIP part is that it needs more data that it does not yet have.

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

This implements a simple algorithm for the batch queue. It waits
until it has a full sequence window and then runs the historical
batch derivation process over that data.

The WIP part is that it needs more data that it does not yet have.
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2022

⚠️ No Changeset found

Latest commit: 1ac560f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere marked this pull request as draft June 13, 2022 19:58
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Also properly slices the queue.
@protolambda protolambda merged commit 624f181 into batch-deriv-v2 Jun 14, 2022
@protolambda protolambda deleted the jg/simple_batch_derivation branch June 14, 2022 20:06
@protolambda
Copy link
Contributor

It auto-deleted after I pushed a merge commit to the base branch. Feel free to re-open or open a new PR for the eager processing of batch data.

theochap pushed a commit that referenced this pull request Dec 10, 2025
Closes #2771

Spec: ethereum-optimism/specs#753

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Jan 14, 2026
Closes #2771

Spec: ethereum-optimism/specs#753

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants