Skip to content

feat: introduce hardhat-deploy-config #2755

Merged
mergify[bot] merged 12 commits intodevelopfrom
sc/hardhat-deploy-config
Jun 14, 2022
Merged

feat: introduce hardhat-deploy-config #2755
mergify[bot] merged 12 commits intodevelopfrom
sc/hardhat-deploy-config

Conversation

@smartcontracts
Copy link
Contributor

Description
Creates a new package hardhat-deploy-config. We're using the same
configuration system for all of our contracts package, so might as well
turn it into a hardhat plugin to avoid duplicating code.

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

🦋 Changeset detected

Latest commit: 397d794

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/hardhat-deploy-config Minor
@eth-optimism/data-transport-layer Patch
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts smartcontracts force-pushed the sc/hardhat-deploy-config branch 2 times, most recently from 294b5ac to bd5e752 Compare June 10, 2022 17:14
@smartcontracts smartcontracts force-pushed the sc/hardhat-deploy-config branch from bd5e752 to 8092e6b Compare June 10, 2022 17:16
Creates a new package hardhat-deploy-config. We're using the same
configuration system for all of our contracts package, so might as well
turn it into a hardhat plugin to avoid duplicating code.
@smartcontracts smartcontracts force-pushed the sc/hardhat-deploy-config branch from 8092e6b to c393b3f Compare June 10, 2022 17:36
@github-actions github-actions bot added the A-ops Area: ops label Jun 10, 2022
@smartcontracts
Copy link
Contributor Author

@tynes to get this over the finish line

@tynes
Copy link
Contributor

tynes commented Jun 10, 2022

The last major problem that I see here is that we lose the ability to have network specific config. There are a few possibilities on how to fix this, going to think about it a bit.

Nvm: this is not true

@tynes tynes marked this pull request as ready for review June 13, 2022 20:46
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks quite reasonable to me.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

Merge failed. Please see automated check logs for more details.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 27234f6 into develop Jun 14, 2022
@mergify mergify bot deleted the sc/hardhat-deploy-config branch June 14, 2022 12:11
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 14, 2022
@mslipper mslipper mentioned this pull request Jun 18, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants