Skip to content

contracts: fix L2CrossDomainMessenger api#2567

Merged
mergify[bot] merged 2 commits intodevelopfrom
fix/l2-xdomain-api
May 16, 2022
Merged

contracts: fix L2CrossDomainMessenger api#2567
mergify[bot] merged 2 commits intodevelopfrom
fix/l2-xdomain-api

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented May 16, 2022

Keep the L2CrossDomainMessenger API backwards
compatible. The l1CrossDomainMessenger getter
was accidentally removed in the refactor.
This commit adds that getter back to the API.
Note that it is a legacy getter and only exists
to ensure that existing applications can still
work with the new contracts.

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Keep the `L2CrossDomainMessenger` API backwards
compatible. The `l1CrossDomainMessenger` getter
was accidentally removed in the refactor.
This commit adds that getter back to the API.
Note that it is a legacy getter and only exists
to ensure that existing applications can still
work with the new contracts.
@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

⚠️ No Changeset found

Latest commit: 75877f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly May 16, 2022 22:19
@tynes
Copy link
Contributor Author

tynes commented May 16, 2022

Closing ethereum-optimism/optimistic-specs#442 in favor of this one

@mergify mergify bot requested a review from Inphi May 16, 2022 22:21
@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit ad6b5de into develop May 16, 2022
@mergify mergify bot deleted the fix/l2-xdomain-api branch May 16, 2022 22:45
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Removes the mention of the `RuntimeActor` from the docs. It was removed
in #2535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants