This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Closed
Conversation
Ensure to have the `l1CrossDomainMessenger` getter on the `L2CrossDomainMessenger` to guarantee backwards compatibility with existing contracts that may be integrated with the `L2CrossDomainMessenger`.
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 51.50% 51.49% -0.02%
==========================================
Files 70 70
Lines 7582 7582
==========================================
- Hits 3905 3904 -1
- Misses 3154 3155 +1
Partials 523 523
Continue to review full report at Codecov.
|
Contributor
Author
|
Closing this in favor of ethereum-optimism/optimism#2567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure to have the
l1CrossDomainMessengergetter on theL2CrossDomainMessengerto guarantee backwards compatibilitywith existing contracts that may be integrated with the
L2CrossDomainMessenger.