Skip to content

Comments

refactor: Remove unused network name param from contract deploy configs#2519

Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
bk62:develop
May 6, 2022
Merged

refactor: Remove unused network name param from contract deploy configs#2519
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
bk62:develop

Conversation

@bk62
Copy link
Contributor

@bk62 bk62 commented May 1, 2022

Description
Removed unused network name parameter from contract deploy configs.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2022

🦋 Changeset detected

Latest commit: e997a2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/sdk Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented May 1, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot requested review from cfromknecht and mslipper May 1, 2022 07:51
@smartcontracts
Copy link
Contributor

Looks good! Just needs a changeset. See here for instructions: https://github.com/ethereum-optimism/optimism/blob/develop/CONTRIBUTING.md#changesets

@bk62 bk62 marked this pull request as ready for review May 2, 2022 10:04
@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

This PR has been added to the merge queue, and will be merged soon.

@smartcontracts
Copy link
Contributor

Perfect, thanks! Feel free to drop an ETH address and I'll send you a contributor NFT.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit b7a04ac into ethereum-optimism:develop May 6, 2022
This was referenced May 10, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
)

## Description

Spiked a dev rpc api to allow to have access to the inner engine state
(task queue length) to help with kurtosis testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused network name parameter in contract deploy configs

3 participants