Skip to content

refactor: Remove unused network name param from contract deploy configs #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
May 6, 2022
Merged

refactor: Remove unused network name param from contract deploy configs #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
940ad48
refactor: Remove unused network name param from contract deploy configs
bk62 May 1, 2022
a5ce28c
chore: Add changeset
bk62 May 2, 2022
e997a2a
Merge branch 'develop' into develop
mergify[bot] May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-flies-care.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/contracts': patch
---

Remove unused network name parameter in contract deploy configs
1 change: 0 additions & 1 deletion packages/contracts/deploy-config/goerli-nightly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DeployConfig } from '../src/deploy-config'

const config: DeployConfig = {
network: 'goerli-nightly',
l1BlockTimeSeconds: 15,
l2BlockGasLimit: 15_000_000,
l2ChainId: 421,
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/deploy-config/goerli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DeployConfig } from '../src/deploy-config'

const config: DeployConfig = {
network: 'goerli',
l1BlockTimeSeconds: 15,
l2BlockGasLimit: 15_000_000,
l2ChainId: 420,
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/deploy-config/kovan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DeployConfig } from '../src/deploy-config'

const config: DeployConfig = {
network: 'kovan',
numDeployConfirmations: 1,
gasPrice: 5_000_000_000,
l1BlockTimeSeconds: 15,
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/deploy-config/local.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DeployConfig } from '../src/deploy-config'

const config: DeployConfig = {
network: 'local',
l1BlockTimeSeconds: 15,
l2BlockGasLimit: 15_000_000,
l2ChainId: 17,
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/deploy-config/mainnet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DeployConfig } from '../src/deploy-config'

const config: DeployConfig = {
network: 'mainnet',
numDeployConfirmations: 4,
gasPrice: 150_000_000_000,
l1BlockTimeSeconds: 15,
Expand Down
9 changes: 0 additions & 9 deletions packages/contracts/src/deploy-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@ import { ethers } from 'ethers'
* Defines the configuration for a deployment.
*/
export interface DeployConfig {
/**
* Name of the network to deploy to. Must be the name of one of the networks listed in
* hardhat.config.ts.
*/
network: string

/**
* Whether or not this network is a forked network.
*/
Expand Down Expand Up @@ -135,9 +129,6 @@ const configSpec: {
default?: any
}
} = {
network: {
type: 'string',
},
isForkedNetwork: {
type: 'boolean',
default: false,
Expand Down