l2geth: Use Google PubSub for transaction syncing#2417
l2geth: Use Google PubSub for transaction syncing#2417Inphi wants to merge 4 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 8d2c620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Inphi
changed the title
.changeset/rotten-dragons-poke.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
You can squash out this changeset
Inphi
force-pushed
the
inphi/geth-pubsub
branch
from
6618701 to
6f90145
Compare
If a deposit causes a problem when being ingested, we don't want to halt the ingestion of all deposits by having the routine be stuck in an infinite loop. The deposit can be replayed via the contracts which will allow for it to go through. There should never be a problem when a deposit is being ingested to cause such an error |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This reverts commit 0c4d4e0.
Otherwise, go/pubsub will buffer messages internally and trigger a timeout when publishing.
|
Hey @Inphi! This PR has merge conflicts. Please fix them before continuing review. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
## Overview Fixes the block label metrics. A recent PR removed them.
3 participants
This reverts the pub/sub feature introduced by eedbebb, with additional fixes. This change will go through nightly so it can be tested properly before being merged.