Skip to content

l2geth: Revert pub/sub transactions#2406

Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
Inphi:inphi/revert-pub-s
Apr 4, 2022
Merged

l2geth: Revert pub/sub transactions#2406
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
Inphi:inphi/revert-pub-s

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Apr 4, 2022

This reverts commits:

The reverted changes will be reintroduced to a separate branch for further testing.

@Inphi Inphi requested review from mslipper and tynes April 4, 2022 17:53
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 7ab9df2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/batch-submitter-service Patch
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested a review from tuxcanfly April 4, 2022 17:53
mslipper
mslipper approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this is a clean revert. The only changes to l2geth between this PR and version 0.5.14 are:

  • Adds a flag for changing the genesis fetch timeout
  • Skip TestWSAttachWelcome
  • Skip some geth console tests that flake in CI
  • The style fix in #2394

@mslipper mslipper added the C-protocol-critical Category: Modifies protocol-critical code label Apr 4, 2022
@mergify mergify bot requested a review from smartcontracts April 4, 2022 18:12
@tynes
Copy link
Contributor

tynes commented Apr 4, 2022

Why are there changes to the batch submitters dependencies?

@mslipper mslipper mentioned this pull request Apr 4, 2022
Closed
@mergify mergify bot requested a review from cfromknecht April 4, 2022 18:47
@Inphi
Copy link
Contributor Author

Inphi commented Apr 4, 2022

Why are there changes to the batch submitters dependencies?

@tynes There was a change to the bss originally per go mod tidy. Introducing the go/pubsub module changed the dependency list in l2geth, and thus bss since it depends on l2geth. This reverts that change.

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@github-actions github-actions bot removed the C-protocol-critical Category: Modifies protocol-critical code label Apr 4, 2022
@mergify mergify bot merged commit 0c4d4e0 into ethereum-optimism:develop Apr 4, 2022
Inphi added a commit to Inphi/optimism that referenced this pull request Apr 5, 2022
@Inphi
Revert "l2geth: Revert pub/sub transactions (ethereum-optimism#2406)"
0029dee 
This reverts commit 0c4d4e0.
adriang-90 pushed a commit to adriang-90/optimism that referenced this pull request Apr 6, 2022
@Inphi @mergify @adriang-90
l2geth: Revert pub/sub transactions (ethereum-optimism#2406)
c369e39 
* Revert "l2geth: Publish transactions to external msg queue"

This reverts commits:
* 9f05c87^..f834886
* 3e016ae^..36991e6

* add changeet

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Inphi added a commit that referenced this pull request Apr 11, 2022
@Inphi
Revert "l2geth: Revert pub/sub transactions (#2406)"
eedbebb 
This reverts commit 0c4d4e0.
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
@Inphi @mergify @nebojsa94
l2geth: Revert pub/sub transactions (ethereum-optimism#2406)
2eb1629 
* Revert "l2geth: Publish transactions to external msg queue"

This reverts commits:
* 9f05c87^..f834886
* 3e016ae^..36991e6

* add changeet

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Inphi added a commit to Inphi/optimism that referenced this pull request May 3, 2022
@Inphi
Revert "l2geth: Revert pub/sub transactions (ethereum-optimism#2406)"
7240436 
This reverts commit 0c4d4e0.
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/sequencer): connect unsafe head watcher from sequencer to e…
8a1ec47 
…ngine (#2406)

## Description

This PR connects the `unsafe_head` watcher from the sequencer actor to
the engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@tynes tynes tynes approved these changes

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

@cfromknecht cfromknecht Awaiting requested review from cfromknecht

Assignees

No one assigned

Labels

A-cannon Area: cannon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Inphi @tynes @mslipper