provider: rpc and signer#234
provider: rpc and signer#234karlfloersch merged 35 commits intoethereum-optimism:masterfrom tynes:provider
Conversation
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
This looks awesome! Very clean & the 700 line ERC20 and 650 line yarn.lock makes this PR actually deceptively small (especially considering all that it's doing). This is awesome! LGTM~
There was a problem hiding this comment.
Ahhh something that could be cool to test is sending a transaction with something like this:
erc20.transfer(...)
The difficulty here is just that at the moment that transaction would only succeed in L2Geth but right now we don't have integration tests of course.
Do you have any tests like this? Would this be something we'd want in these unit tests or should we wait until we have the integration tests repo?
There was a problem hiding this comment.
Good thinking! I'm leaning towards getting that into the integration tests repo so that I can focus on some other tickets in the meantime
|
Oh it looks like there's a |
|
I fixed the conflict with |
|
Also removed |
|
Renamed the package to |
|
@tynes I think this is good to go and totally approve of renaming it to just |
|
Fixed the linting errors |
|
Awesome!!! |
### Description Breaks out the small batch decoding fix from #234.
### Description Breaks out the small batch decoding fix from #234.
Seems like when `reth-optimism-trie` depends on `reth-db-api` indirectly, the doctest crate couldn’t resolve `reth_db_api::…` and failing. Closes #233 Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
2 participants
Description
Adds a new package that includes an
OptimismProvider. This provider includes a signer that uses theeth_signsignature hashing scheme.Questions
Metadata
Fixes
Contributing Agreement