Skip to content

Published new packages#235

Merged
K-Ho merged 3 commits intomasterfrom
YAS-632/Synthetix/NewPackages
Aug 28, 2020
Merged

Published new packages#235
K-Ho merged 3 commits intomasterfrom
YAS-632/Synthetix/NewPackages

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Aug 27, 2020

Description

Updated package.json files for newly published packages

Questions

Question for @kfichter - can we make the contracts and ovm-toolchain packages public?

Fixes

  • Fixes #YAS-632

Contributing Agreement

@smartcontracts
Copy link
Contributor

Question for @kfichter - can we make the contracts and ovm-toolchain packages public?

This is a serious headache right now caused by quirks within buidler. buidler expects both plugins and typescript/ts-node to exist within the same node_modules folder as buidler itself (which is a bit silly, to be honest). yarn hoisting packages up to the root to reduce dependencies ends up breaking buidler. So we have to use the nohoist option in our package.json files, which only works if private: true.

I haven't checked recently see if this has been solved. I'll make an issue on buidler if not. We could possibly use symlinks to trick buidler into working correctly, but that's a bit hacky.

Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot 🔥 right here. Merrrrrge-able!

"main": "build/index.js",
"files": [
"build/**/*.js",
"build/contracts/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we export these for btw?

Copy link
Contributor Author

@K-Ho K-Ho Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K-Ho K-Ho merged commit 5b06241 into master Aug 28, 2020
@K-Ho K-Ho deleted the YAS-632/Synthetix/NewPackages branch September 1, 2020 20:31
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
xibao-nr pushed a commit to node-real/combo-optimism that referenced this pull request Feb 19, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Breaks out the small batch decoding fix from #234.
emhane pushed a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants